Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumetric Fog stops working when enabling shadows for omnilight or spotlight #50330

Closed
jcostello opened this issue Jul 10, 2021 · 9 comments
Closed

Comments

@jcostello
Copy link
Contributor

Godot version

v4.0.dev.calinou [5db1f8b]

System information

Mx Linux (Debian Based)

Issue description

When enabling shadows for an omnilight or spotlight, volumetric fog stops working.

Steps to reproduce

Add environment
Enable Volumetric Fog
Add Omni Light (Make sure that its contributes to the Volumetric Fog)
Enable Omni Light Shadow
Fog stops working (or at least the light stops contributing)

fog.mp4

Minimal reproduction project

There is no reason to add minimal project since once the light's shadow is enabled it never contributes to the fog again even if the shadow is disabled. So all steps must be done to reproduce the issue.

@Calinou
Copy link
Member

Calinou commented Jul 10, 2021

I couldn't reproduce this with OmniLights yesterday, but I couldn't get SpotLights to display in volumetric fog (even though there were no error messages).

@mrjustaguy
Copy link
Contributor

I can confirm the issue on both OmniLights and SpotLights on v4.0.dev.custom_build [e3744d2fe]
Note - SpotLights are much more difficult to see the effect of Volumetric Fog, try to view them with black sky (custom color) that might help, unless it's a bug.

Also Shadows cannot be turned off for both of those, not sure for directional, I'm not sure if this is a Known issue atm.

@Calinou
Copy link
Member

Calinou commented Jul 10, 2021

Also Shadows cannot be turned off for both of those, not sure for directional, I'm not sure if this is a Known issue atm.

Disabling shadows for point lights will only apply once you reload the scene. I reported it here: #50343

@jcostello
Copy link
Contributor Author

@Calinou I can confirm this for Point Lights but not for Spot Lights. For some reason the fog still broken even if I reload the scene

@clayjohn
Copy link
Member

clayjohn commented Dec 1, 2021

This may have been fixed by #53353

@Calinou
Copy link
Member

Calinou commented Feb 6, 2022

I can't reproduce this on commit 9d1626b. However, I can reproduce a similar issue but only for SpotLight3D (and not OmniLight3D): #57722

@Jamsers
Copy link

Jamsers commented Oct 20, 2023

You won't believe this but somehow #50330 returned 😕

Changing the "quality scaling" to high enables shadows for the lamppost omnilights, this happens:

Huh.mp4

But if you change render scaling in-game, the issue fixes itself? 🤔

I've detailed reproduction steps at Bistro-Demo-Tweaked's #16.

@AThousandShips
Copy link
Member

Please open a new bug report as this is a separate issue, it causing the same problem means it's a new issue having the same effect

@Calinou
Copy link
Member

Calinou commented Oct 20, 2023

Issue opened: #83685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants