Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot 4: impossible to restart after creating a TextureAtlas from PNGs #54817

Closed
gustavi opened this issue Nov 9, 2021 · 3 comments · Fixed by #68324
Closed

Godot 4: impossible to restart after creating a TextureAtlas from PNGs #54817

gustavi opened this issue Nov 9, 2021 · 3 comments · Fixed by #68324
Labels
bug confirmed regression topic:editor topic:import
Milestone
4.0

Comments

@gustavi
Copy link

gustavi commented Nov 9, 2021

Godot version

v4.0.dev.20211108.official.596865366

System information

Windows 10 64bit - Vulkan API 1.2.141 - GeForce GTX 1660 SUPER

Issue description

When you create a TextureAtlas from PNGs Godot as you to restart and can not start anymore without remove PNGs .import files.

I didn't find any related issue in the past months on GitHub tracker. I only tried it on Windows. I thing it's the same with other images. Same behavior in Godot_v4.0-dev.20211027.

Steps to reproduce

  1. Create a blank project
  2. Add PNGs (I used https://www.kenney.nl/assets/toon-characters-1)
  3. Select PNG in editor (Screenshot 1)
  4. Select "Import" tab on left sidebar
  5. Import as TextureAtlas
  6. Select "Atlas file" and give it a name (the name does not matter)
  7. Select "Reimport" button
  8. Select "Save Scenes, Re-Import, and Restart" button
  9. Wait the engine restart and display a blank pop-up named "Load Errors" (Screenshot 2)

image

image

Minimal reproduction project

texture-atlas_before.zip

texture-atlas_after.zip
@Calinou Calinou added this to the 4.0 milestone Nov 10, 2021
@Calinou
Copy link
Member

Calinou commented Nov 10, 2021

@gustavi Can you reproduce this on 3.4 as well, or only in master?

@gustavi
Copy link
Author

gustavi commented Nov 10, 2021 •
edited
Loading

  • 3.4 : 🟢 atlas creation works
  • 4.0-dev.20210727 : 🔴 broken
  • 4.0 : 🔴 broken

(tested on Windows only)

@gustavi gustavi changed the title Godot can not restart after creating a TextureAtlas from PNGs Godot 4: impossible to restart after creating a TextureAtlas from PNGs Mar 14, 2022
@KoBeWi
Copy link
Member

KoBeWi commented Apr 25, 2022

Still valid in 6a9115b

@KoBeWi KoBeWi moved this to Todo in 4.x Priority Issues Apr 25, 2022
@EspeuteClement EspeuteClement mentioned this issue May 8, 2022
Closed
EspeuteClement added a commit to EspeuteClement/godot that referenced this issue May 9, 2022
@EspeuteClement
Fixing crash when reimporting AtlasTextures
1b9a2d1 
The crash was caused by the reimport_files function trying to reimport the atlas file multiple times using multithreading, which caused deadlocks and hang the editor.
This fix prevents files from being added to the reimport_files array if they are already present inside of it.

Fixes godotengine#54817
@KoBeWi KoBeWi mentioned this issue Jun 21, 2022
Closed
@KoBeWi KoBeWi moved this from Todo to In Progress in 4.x Priority Issues Jun 23, 2022
@chrisizeful chrisizeful mentioned this issue Sep 23, 2022
Closed
@felbecker felbecker mentioned this issue Oct 15, 2022
Closed
@kleonc kleonc mentioned this issue Nov 6, 2022
Merged
Repository owner moved this from In Progress to Done in 4.x Priority Issues Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed regression topic:editor topic:import
Projects
4.x Priority Issues
Archived in project
Milestone
4.0
3 participants
@Calinou @KoBeWi @gustavi