Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting any preset on linux removes MacOS codesigning settings #57065

Closed
ehmprah opened this issue Jan 22, 2022 · 2 comments · Fixed by #57072
Closed

Exporting any preset on linux removes MacOS codesigning settings #57065

ehmprah opened this issue Jan 22, 2022 · 2 comments · Fixed by #57072

Comments

@ehmprah
Copy link

ehmprah commented Jan 22, 2022

Godot version

3.4.stable

System information

PopOS_! 21.10

Issue description

After exporting a build on my linux machine, every line beginning with codesign/* or notarization/* are removed from the export_presets.cfg file. I understand that these settings are not available on a linux machine, but Godot could at least leave the presets intact so they're still working the next time I'm using my Mac.

How about just disabling the inputs on Windows / Linux machines but showing them so you see that there's something there in the export editor and the values are kept upon regerenerating the export_presets.cfg?

Steps to reproduce

See above.

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Jan 22, 2022

This is likely resolved by #51310, which will be included in Godot 3.5 (#51550). It's not included in 3.5 beta1, but you could try compiling the 3.x branch from source.

There is currently no way to have disabled/read-only export options, so such a system would need to be implemented in a patch release to resolve this in 3.4.3. However, doing so would be against the release policy since patch releases should only contain bug fixes from now on (and no new features). Therefore, I'm not sure if it's worth the effort.

We could add dummy options that are unused on platforms other than macOS, but it could be confusing.

@bruvzg
Copy link
Member

bruvzg commented Jan 22, 2022

This is likely resolved by #51310, which will be included in Godot 3.5

Only for some option that are now supported on Linux and Windows. Notarization options will be still removed. We need to add some way to disable options, instead of removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants