Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS export, 3.x] Implements ad-hoc signing on Linux/Windows. #51550

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[macOS export, 3.x] Implements ad-hoc signing on Linux/Windows. #51550

merged 1 commit into from
Jan 20, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 12, 2021

Backport of #51310 for 3.x

@bruvzg bruvzg added this to the 3.4 milestone Aug 12, 2021
@bruvzg bruvzg requested review from a team as code owners August 12, 2021 07:40
@bruvzg bruvzg mentioned this pull request Aug 13, 2021
Closed
@knightofiam knightofiam mentioned this pull request Aug 18, 2021
Closed
@akien-mga akien-mga modified the milestones: 3.4, 3.5 Oct 20, 2021
akien-mga
akien-mga approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge once rebased and reworked like the master PR.

The platform/*/export/ refactor was also done in 3.4 (#52515) so the same logic can be used here.

@bruvzg bruvzg marked this pull request as draft January 18, 2022 12:07
@bruvzg

This comment has been minimized.

Sign in to view
@bruvzg
[macOS export, 3.x] Implements ad-hoc signing on Linux/Windows, adds …
30ee208 
…extra privacy settings, entitlements warnings and error checking.
@bruvzg bruvzg marked this pull request as ready for review January 20, 2022 08:49
@bruvzg
Copy link
Member Author

bruvzg commented Jan 20, 2022

need a bit more work, it's no longer working as expected.

Seems to work fine now. There's no PoolVector list initializers in 3.x, so I left this part as is.

@akien-mga akien-mga merged commit ca1968b into godotengine:3.x Jan 20, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the 🍎🍎🍐🍏🍎 branch January 20, 2022 09:36
@Calinou Calinou mentioned this pull request Jan 22, 2022
Closed
@bruvzg bruvzg mentioned this pull request Jan 31, 2022
Merged
@Calinou Calinou mentioned this pull request Feb 19, 2022
Open
@akien-mga akien-mga mentioned this pull request Jul 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos topic:export usability
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga