Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot 4: Need to press "Directory Up" button twice in path with slash at the end #58504

Closed
Akylzhan opened this issue Feb 24, 2022 · 4 comments
Closed

Godot 4: Need to press "Directory Up" button twice in path with slash at the end #58504

Akylzhan opened this issue Feb 24, 2022 · 4 comments
Labels
bug enhancement topic:editor topic:gui
Milestone
4.2

Comments

@Akylzhan
Copy link

Godot version

4.0 dev

System information

pop-os 5.15.15, Vulkan

Issue description

As the title says, if you go to any favorite folder in EditorFileDialog and press Directory Up button it does nothing, but removes / in path. Same happens if you copy and paste the path with / at the end. Would be nice if there was no need to press button twice

Steps to reproduce

.

Minimal reproduction project

No response
@Akylzhan
Copy link
Author

If it's OK, I can work on this.

@Akylzhan Akylzhan changed the title Godot 4: Need to press "Directory Up" button twice when you go to favorite folder in EditorFileDialog Godot 4: Need to press "Directory Up" button twice when you are in path with slash at the end Feb 24, 2022
@Akylzhan Akylzhan changed the title Godot 4: Need to press "Directory Up" button twice when you are in path with slash at the end Godot 4: Need to press "Directory Up" button twice in path with slash at the end Feb 24, 2022
@Chaosus Chaosus added this to the 4.0 milestone Feb 24, 2022
@Chaosus Chaosus added the bug label Feb 24, 2022
@Calinou
Copy link
Member

Calinou commented Feb 24, 2022

If it's OK, I can work on this.

Sure, feel free to open a pull request for this 🙂

@Akylzhan Akylzhan mentioned this issue Feb 24, 2022
Closed
@KoBeWi KoBeWi moved this to To Assess in 4.x Priority Issues Mar 27, 2022
@KoBeWi KoBeWi moved this from To Assess to In Progress in 4.x Priority Issues Mar 27, 2022
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 13, 2023
@akien-mga akien-mga modified the milestones: 4.1, 4.2 Jun 15, 2023
@Alex2782
Copy link
Contributor

@akien-mga
This problem is probably already fixed. #80821

At first I also wanted to adjust the function String::get_base_dir() as in this PR: #58508 (Label needs work)
But the effects on other functions were not clear to me.

@akien-mga
Copy link
Member

Fixed by #80821.

@github-project-automation github-project-automation bot moved this from In Progress to Done in 4.x Priority Issues Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement topic:editor topic:gui
Projects
4.x Priority Issues
Archived in project
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

Fix get_base_dir returning same path, if slash is in the end
5 participants
@Calinou @Chaosus @akien-mga @Akylzhan @Alex2782