-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Go to parent folder" in EditorFileDialog
#80821
Conversation
fe836c2
to
802a96f
Compare
EditorFileDialog
I remember we have workaround code for the |
no problems Screen-2023-09-06-004217.mp4 |
802a96f
to
b030209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce the issue myself, but the fix looks fine.
b030209
to
40046bc
Compare
maybe in one line? or better? void EditorFileDialog::_go_up() {
String up_dir = get_current_dir().trim_suffix("/").get_base_dir();
dir_access->change_dir(up_dir);
update_file_list();
update_dir();
_push_history();
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks! |
Cherry-picked for 4.1.3. |
EditorFileDialog
EditorFileDialog
Fixes: #80750
I am not sure if '/' character may be removed in the function
get_base_dir()
as well. (190 results in 80 files)