Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty popup when right-clicking favorites #60921

Closed
KoBeWi opened this issue May 10, 2022 · 7 comments · Fixed by #61001
Closed

Empty popup when right-clicking favorites #60921

KoBeWi opened this issue May 10, 2022 · 7 comments · Fixed by #61001
Labels
bug platform:windows topic:editor
Milestone
4.0

Comments

@KoBeWi
Copy link
Member

KoBeWi commented May 10, 2022

Godot version

5dae0cb

System information

Windows 10 x64

Issue description

When you right-click any file in filesystem dock and then right-click favorites, you end up with empty popup.
godot windows tools 64_kV431JxXxN
Normally right-clicking favorites doesn't do anything, so likely what happens is that you have a popup visible and then it gets
cleared.

Steps to reproduce

  1. Right-click any file in filesystem dock
  2. Right-click favorites item

Minimal reproduction project

No response
@KoBeWi KoBeWi mentioned this issue May 10, 2022
Merged
@akien-mga akien-mga added this to the 4.0 milestone May 10, 2022
@akien-mga
Copy link
Member

I can't reproduce it on Linux X11, it might be Windows specific. Seems to happen both on Windows 10 for @KoBeWi and Windows 11 for @lufog.

@KoBeWi KoBeWi moved this to To Assess in 4.x Priority Issues May 10, 2022
@KoBeWi KoBeWi moved this from To Assess to Todo in 4.x Priority Issues May 10, 2022
@KoBeWi
Copy link
Member Author

KoBeWi commented May 10, 2022

Likely caused by #59287
The popup should just disappear.

@akien-mga
Copy link
Member

CC @godotengine/windows @Vitika9

@derammo derammo mentioned this issue May 11, 2022
Closed
@derammo
Copy link
Contributor

derammo commented May 12, 2022

I'm close to fixing this without disabling right clicks, I believe.

@derammo
Copy link
Contributor

derammo commented May 12, 2022 •
edited
Loading

[deleted, posted on wrong issue]

@derammo
Copy link
Contributor

derammo commented May 12, 2022 •
edited
Loading

Likely caused by 59287 The popup should just disappear.

@KoBeWi yes, all my testing is with that PR reverted. With the PR, it currently happens 100% of the time. I am not entirely sure yet if I have seen it from a race condition with the PR reverted.

@derammo
Copy link
Contributor

derammo commented May 13, 2022

I have a fix, just waiting on PR in the same area to go in first for clean rebase.

derammo added a commit to derammo/godot that referenced this issue May 13, 2022
@derammo
popup deferred hide suppressed if reopened
47d0dc8 
popup no longer tries to close itself a second time
popup no longer closes after having been reopened
fixed bug in RenameDialog not calling base (by inspection)
fixes godotengine#59181
fixes godotengine#60921
reverts godotengine#59287
@derammo derammo mentioned this issue May 13, 2022
Merged
Repository owner moved this from Todo to Done in 4.x Priority Issues May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug platform:windows topic:editor
Projects
4.x Priority Issues
Archived in project
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

popup deferred hide suppressed if reopened on Windows platform derammo/godot
3 participants
@derammo @KoBeWi @akien-mga