Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Scons float=64 option is not passed to the Visual Studio build command line with vsproj=yes #66008

Closed
Sniperchang opened this issue Sep 17, 2022 · 0 comments · Fixed by #66777

Comments

@Sniperchang
Copy link

Godot version

v4.0.beta.custom_build [57bdddc]

System information

Windows 10, Visual Studio 2019

Issue description

It seems when generating a Visual Studio project via Scons with the float=64, the generated command line doesn't include float=64 as a scon parameter.

The REAL_T_IS_DOUBLE definition does show up on the pre-processor definitions for IntelliSense, but nothing related is included in the build command lines. When building from within visual studio, this causes the build to exclude REAL_T_IS_DOUBLE.

I would expect the build/rebuild commands to include the appropriate scons paremeter (probably float=64) so that the build defines REAL_T_IS_DOUBLE when compiling from within visual studio.

Steps to reproduce

On a windows machine with visual studio, build godot with the float=64 and vsproj=yes parameters, example:
scons -j14 p=windows vsproj=yes target=release_debug float=64
Open the godot.sln file in visual studio and inspect the nmake tab of the godot project properties. The command line strings are missing float64 parameters.

The problem is more visible when creating a project:

  1. Create and save a godot project with the godot binary scons has correctly built (not visual studio, should be something like godot.windows.double.opt.tools.x86_64.exe)
  2. Close godot, open the godot.sln in vs, build and run from within vs.
  3. Observe the newly built binary via visual studio has a path name lacking "double", something like godot.windows.opt.tools.x86_64.exe.
  4. Try opening the earlier saved project, it will prompt a warning about the project requiring Double Precision (because the vs build lacks it)

Minimal reproduction project

No response

@Calinou Calinou added this to the 4.0 milestone Sep 17, 2022
@akien-mga akien-mga changed the title The Scon float=64 option is not passed to the visual studio build command line as expected The Scons float=64 option is not passed to the Visual Studio build command line with vsproj=yes Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants