Enhancements to VS solution generation #66777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 3, 2022
TechnoPorg
force-pushed
the
msvs-better-options
branch
2 times, most recently
from
8d15d4d
to
6a59d3e
Compare
This adds support for building solutions with dev_mode and/or float=64 enabled. Additionally, it adds solution generation to the Windows CI to catch future regressions.
TechnoPorg
force-pushed
the
msvs-better-options
branch
from
6a59d3e
to
f124616
Compare
|
I have also added |
akien-mga
approved these changes
Oct 5, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66008.
Adds support for the
dev_mode=yesandfloat=64command line options when generating a Visual Studio solution.This also includes the changes from #66718, so that solution generation works at all.
The whole solution generation system feels messy to me, but I'm not sure if there's a better way to do it.