Heap overflow in windows icon code

[jordo]

Godot version

3.X

System information

windows

Issue description

Exception thrown at 0x00007FF6FB951270 in godot.windows.opt.tools.64.s.exe: 0xE0736171: Access violation reading location 0x00000443B8510000.
=================================================================
==30072==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x11fd0fc43576 at pc 0x7ff6fb95d51c bp 0x0080bbff9dc0 sp 0x0080bbff9540
WRITE of size 16 at 0x11fd0fc43576 thread T0
    #0 0x7ff6fb95d549 in __asan_wrap_memmove D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\sanitizer_common\sanitizer_common_interceptors.inc:794
    #1 0x7ff700155dd7 in _fread_nolock_s minkernel\crts\ucrt\src\appcrt\stdio\fread.cpp:131
    #2 0x7ff700155fc8 in fread_s minkernel\crts\ucrt\src\appcrt\stdio\fread.cpp:56
    #3 0x7ff700155f2b in fread minkernel\crts\ucrt\src\appcrt\stdio\fread.cpp:239
    #4 0x7ff6fce2a167 in FileAccessWindows::get_buffer C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\drivers\windows\file_access_windows.cpp:261
    #5 0x7ff6fb9236ed in OS_Windows::set_native_icon C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\os_windows.cpp:3061
    #6 0x7ff6fb9906a4 in Main::start C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\main\main.cpp:2121
    #7 0x7ff6fb8f9b17 in widechar_main C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\godot_windows.cpp:174
    #8 0x7ff6fb8f982b in _main C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\godot_windows.cpp:198
    #9 0x7ff6fb8f9c88 in main C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\godot_windows.cpp:210
    #10 0x7ff70012cc53 in __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
    #11 0x7ff9f8837613 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017613)
    #12 0x7ff9fa7026a0 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x1800526a0)

0x11fd0fc43576 is located 0 bytes to the right of 38-byte region [0x11fd0fc43550,0x11fd0fc43576)
allocated by thread T0 here:
    #0 0x7ff6fb959617 in realloc D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\lib\asan\asan_malloc_win.cpp:144
    #1 0x7ff6ff928697 in Memory::realloc_static C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\core\os\memory.cpp:149
    #2 0x7ff6fb9236a8 in OS_Windows::set_native_icon C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\os_windows.cpp:3060
    #3 0x7ff6fb9906a4 in Main::start C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\main\main.cpp:2121
    #4 0x7ff6fb8f9b17 in widechar_main C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\godot_windows.cpp:174
    #5 0x7ff6fb8f982b in _main C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\godot_windows.cpp:198
    #6 0x7ff6fb8f9c88 in main C:\Users\jordan\WINTERPIXEL\PROJECTS\upguys\godot\platform\windows\godot_windows.cpp:210
    #7 0x7ff70012cc53 in __scrt_common_main_seh D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288
    #8 0x7ff9f8837613 in BaseThreadInitThunk+0x13 (C:\Windows\System32\KERNEL32.DLL+0x180017613)
    #9 0x7ff9fa7026a0 in RtlUserThreadStart+0x20 (C:\Windows\SYSTEM32\ntdll.dll+0x1800526a0)

Steps to reproduce

Run godot with asan, and launch a scene from a 'tools' build without the editor argument -e.

Minimal reproduction project

Will submit a fix shortly...

[akien-mga]

Fixed by #71699.