-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dialog does not show global classes from addons inside subfolders #78400
Comments
In the MRP you have uploaded, you can see in This feels like the issue is in the Editor code that determines which classes should be added to the dialog. To confirm I have ported the MRP to GDScript and I am able to reproduce this so it doesn't seem exclusive to C#. This is why we usually ask users to provide a GDScript MRP even for C# issues, it allow us to confirm if it's a C# issue or if the issue may be somewhere else. The issue is likely in this condition in the create_dialog: godot/editor/create_dialog.cpp Line 158 in a83eb16
GDScript MRP: GlobalClassTestGDScript.zip |
Thank you for pointing that out. I did not think of porting to GDScript. btw should we rename the issue? |
Yes, it's likely the same cause.
Oh yeah, feel free to rename it to something more appropiate now that we know it's also happening with GDScript's |
[GlobalClass]
does not work in nested addonsThese should now appear in the Create Node dialog. They don't, but this is an editor bug (godotengine/godot#78400 )
Godot version
4.1.beta1.mono
System information
Godot v4.1.beta1.mono - macOS 13.3.1 - Vulkan (Forward+) - integrated Apple M1 Pro - Apple M1 Pro (8 Threads)
Issue description
The new
GlobalClass
attribute for registering global types in C# (#72619) does not seem to work in nested addons, i.e. addons that are placed within a subfolder of theaddons
directory (res://addons/**/<addon>
).Placing addons inside of subfolders is supported accroding to #43734
Edit: as confirmed by @raulsntos the same problem is present for GDScript.
Detailed showcase of the problem
Given the following project:
Where the
CustomProjectNode.cs
,CustomAddonNode.cs
, andCustomSubfolderAddonNode.cs
are implemented like this:And both addons are enabled in the project settings, the
CustomSubfolderAddonNode
does not show up when adding a new node:Steps to reproduce
GlobalClass
attributeaddons
Minimal reproduction project
GlobalClassTest.zip
The text was updated successfully, but these errors were encountered: