Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Whole Words" search doesn't detect word boundary inside query string #82693

Closed
BrianMacIntosh opened this issue Oct 2, 2023 · 0 comments · Fixed by #82694
Closed

"Whole Words" search doesn't detect word boundary inside query string #82693

BrianMacIntosh opened this issue Oct 2, 2023 · 0 comments · Fixed by #82694

Comments

@BrianMacIntosh
Copy link
Contributor

Godot version

v4.1.1.stable.official [bd6af8e]

System information

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Compatibility) - AMD Radeon RX 5700 XT (Advanced Micro Devices, Inc.; 31.0.12027.9001) - Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz (6 Threads)

Issue description

Most code editors (tested Visual Studio, VS Code, Notepad++) check for word boundaries on the edges of the possible match when doing Whole Words searches. Godot, however, only checks for non-word characters outside the possible match, not inside.

For example, most editors will find .func in variable.func when performing a Whole Words search, but Godot finds nothing.

This behavior is useful when I want to find uses of a member variable. I can do a Whole Words search for .member and it will match class.member but not var member or class.membership.

Steps to reproduce

  1. Create a script with the following content:
extends Node

func _process(delta: float) -> void:
	self.myfunc()
	self.myfunction()
	pass

func myfunc():
	pass

func myfunction():
	pass
  1. Perform a Whole Words search for .myfunc.
  2. Observe that no matches are found.

Minimal reproduction project

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants