Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Whole Words" search can detect word boundaries inside the search term. #82694

Merged
merged 1 commit into from
Oct 5, 2023
Merged

"Whole Words" search can detect word boundaries inside the search term. #82694

merged 1 commit into from
Oct 5, 2023

Conversation

BrianMacIntosh
Copy link
Contributor

@BrianMacIntosh BrianMacIntosh commented Oct 2, 2023 •
edited by akien-mga
Loading

For example, searching for ".func" will now match in "a.func" even with Whole Words enabled.
For more information, see issue #82693.

Bugsquad edit:

@BrianMacIntosh
"Whole Words" search can detect word boundaries inside the search term.
676627e 
For example, searching for ".func" will now match in "a.func" even with Whole Words enabled.
@BrianMacIntosh BrianMacIntosh requested review from a team as code owners October 2, 2023 21:10
@Calinou Calinou added this to the 4.2 milestone Oct 2, 2023
@Calinou Calinou added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 2, 2023
Calinou
Calinou approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master bfd78bb), it works as expected. Code looks good to me too.

Screenshot_20231005_025358

Screenshot_20231005_025405

Screenshot_20231005_025410

Screenshot_20231005_025429

Screenshot_20231005_025436

Kudos for adding more tests 🙂

@akien-mga akien-mga merged commit aa554e8 into godotengine:master Oct 5, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

"Whole Words" search doesn't detect word boundary inside query string
4 participants
@BrianMacIntosh @akien-mga @YuriSizov @Calinou