Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2 dev6 node AnimationPlayer Play Not effective #82905

Closed
wsqrin opened this issue Oct 6, 2023 · 6 comments · Fixed by #83030
Closed

4.2 dev6 node AnimationPlayer Play Not effective #82905

wsqrin opened this issue Oct 6, 2023 · 6 comments · Fixed by #83030

Comments

@wsqrin
Copy link

wsqrin commented Oct 6, 2023

Godot version

4.2 dev 6 mono

System information

win11 22H2

Issue description

4.2 dev6 node AnimationPlayer Play Not effective but 4.2 dev5 is normal

Steps to reproduce

public override void _PhysicsProcess(double delta)
{
    ChangeAnimation();
}

private void ChangeAnimation()
{
    var anim = Velocity.X switch
    {
        < 0 => "left",
        > 0 => "right",
        _ => "down"
    };

    if (Velocity.Y < 0) anim = "up";

    animation_play?.Play("walk-" + anim);
}

Minimal reproduction project

public override void _Ready()
{
    animation_play = GetNode<AnimationPlayer>("AnimationPlayer");
}
@AThousandShips
Copy link
Member

AThousandShips commented Oct 6, 2023

Can you please provide an MRP to make this easier to test:

  • A small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).
  • Drag and drop a ZIP archive to upload it. Do not select another field until the project is done uploading.
  • Note for C# users: If your issue is not Mono-specific, please upload a minimal reproduction project written in GDScript or VisualScript. This will make it easier for contributors to reproduce the issue locally as not everyone has a Mono setup available.

No information about the animations were provided so very difficult to test this, so please provide a project, and make sure to convert the example code to GDScript, so more people can test it

You're also calling play repeatedly which would reset the animation each time AFAIK

@akien-mga
Copy link
Member

Likely duplicate of #82828?

@AThousandShips
Copy link
Member

If so then it would have been fixed by #82898

@kyle-wannacott
Copy link

I'm on 4.2 dev 6 mono as well.

There is definitely some funky stuff going on, but it's only for some animations. Like my player character has gone invisible (none of the animations show) and animal running animations are effected which sounds like #82898 (which probably isn't in the build I'm using yet):

It's late, I'll investigate/retry tomorrow.

@kyle-wannacott
Copy link

kyle-wannacott commented Oct 7, 2023

I compiled from source; looks like #82898 fixed the animal running animations that loop. Although, my player character is still invisible, so it's probably a different issue; I'll look into reproducing it in a minimal project and I guess open it in a separate issue.

@kyle-wannacott
Copy link

kyle-wannacott commented Oct 7, 2023

Update for invisible character: looks like its this issue: #82949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants