Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGs with <mask> in them broke, affecting the display of several editor icons #82982

Closed
MewPurPur opened this issue Oct 7, 2023 · 4 comments · Fixed by #83281
Closed

SVGs with <mask> in them broke, affecting the display of several editor icons #82982

MewPurPur opened this issue Oct 7, 2023 · 4 comments · Fixed by #83281
Labels
bug topic:editor topic:import topic:thirdparty
Milestone
4.2

Comments

@MewPurPur
Copy link
Contributor

MewPurPur commented Oct 7, 2023 •
edited
Loading

Godot version

Godot v4.2.dev6 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)

System information

Godot v4.2.dev6 - Pop!_OS 22.04 LTS - X11 - Vulkan (Forward+) - integrated Intel(R) Graphics (ADL GT2) () - 12th Gen Intel(R) Core(TM) i5-1235U (12 Threads)

Issue description

Our SVG icons that use the <mask> element broke.

image

Most likely caused by #82542 but I haven't tested it. Technically, <mask> is not required for these SVGs, but it allows for easy clean cutouts which is why I used them here.

Steps to reproduce

Open Godot and find them

Minimal reproduction project

N/A
@MewPurPur
Copy link
Contributor Author

@capnm

@Calinou Calinou changed the title SVGs with <mask> in them broke SVGs with <mask> in them broke, affecting the display of several editor icons Oct 7, 2023
@capnm
Copy link
Contributor

capnm commented Oct 8, 2023 •
edited
Loading

@MewPurPur Thanks for the report. I can take a look next week. A large PNG before/after image would be helpful.

@MewPurPur
Copy link
Contributor Author

MewPurPur commented Oct 8, 2023 •
edited
Loading

image

From my slightly outdated dev build. (2-3 weeks old)

@capnm
Copy link
Contributor

capnm commented Oct 9, 2023

upscaled-png-diff

@capnm capnm mentioned this issue Oct 9, 2023
Closed
@capnm capnm mentioned this issue Oct 13, 2023
Merged
@akien-mga akien-mga added this to the 4.2 milestone Oct 16, 2023
ProbablyWorks pushed a commit to ProbablyWorks/godot that referenced this issue Oct 22, 2023
@capnm @ProbablyWorks
ThorVG: Update to v0.11.1
fa16115 
https://github.com/thorvg/thorvg/releases/tag/v0.11.1

Godot related:
+ [SwEngine] Enhanced the quality of the dash line corners.
+ [SVG] Fixed a regression bug related to maskContentUnit,
	userSpaceOnUse/objectBoundingBox.

Fixes godotengine#82982 icons.
Fixes godotengine#83198 svg ← png/jpg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor topic:import topic:thirdparty
Projects
None yet
Milestone
4.2
Development

Successfully merging a pull request may close this issue.

ThorVG: update to v0.11.1 capnm/godot4
4 participants
@Calinou @capnm @akien-mga @MewPurPur