Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11 splash screen is usually not right size #83693

Open
rakkarage opened this issue Oct 20, 2023 · 5 comments
Open

x11 splash screen is usually not right size #83693

rakkarage opened this issue Oct 20, 2023 · 5 comments

Comments

@rakkarage
Copy link
Contributor

Godot version

v4.2.dev.custom_build [918f046]

System information

Godot v4.2.dev (918f046) - Ubuntu 23.10 23.10 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 6600 (RADV NAVI23) () - 12th Gen Intel(R) Core(TM) i5-12400F (12 Threads)

Issue description

Screenshot from 2023-10-19 15-29-12

When loading a project, sometimes (usually) the splash screen wrong size?

#83692

Steps to reproduce

Open any project from command line or Project Manager.

Minimal reproduction project

n/a

@Riteo
Copy link
Contributor

Riteo commented Oct 21, 2023

IIRC the splash gets immediately rendered as the project's window size. It then can't be resized once its drawn because everything else is initializing so the main thread is busy.

We're having similar issues on Wayland but that's the nature of the splash I suppose.

@rakkarage
Copy link
Contributor Author

I am on wayland... this "fixes" that i think. I just said x11 cuz that filename.

Ubuntu 23.10 23.10 - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX 6600 (RADV NAVI23) () - 12th Gen Intel(R) Core(TM) i5-12400F (12 Threads)

@Riteo
Copy link
Contributor

Riteo commented Oct 22, 2023

Uh, right, I'll also write it here. I missed the fact that you're running it over XWayland, which is known to be a bit funky with window attributes and (see #80036) and a lot of other things (see #78581).

While this doesn't necessarily exclude that it might be an actual X11 bug I'd also be cautious about testing and fixing bugs while only testing on XWayland.

@lostminds
Copy link

IIRC the splash gets immediately rendered as the project's window size. It then can't be resized once its drawn because everything else is initializing so the main thread is busy.

There's another related issue to this for me on macOS. That when launching the game if you change the game window size on startup the OS this will immediately resize the window but the splash screen will not be re-rendered or cleared. So similar to the screenshot above it remains shown in the corner of the window (but bottom right for me) for a few frames while the initial scene is loaded. Looks kind of buggy, and I wish there was a way to clear the window when the splash sequence ends so it's at least a solid color for the moment it takes to load the initial scene.

@Riteo
Copy link
Contributor

Riteo commented Feb 13, 2024

@lostminds to be clear, this is issue is not exclusive to Linux/BSD, as the splash drawing is platform agnostic. You're having the same issue.

Edit: I added the platform:macos label as it got confirmed there. I have no idea if windows even allows window resizing at this stage, but if it could we'd probably see the same thing as nothing ever gets redrawn until everything is fully initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants