Always wait for effective resizing? #83692
Conversation
| @@ -2278,7 +2278,8 @@ void DisplayServerX11::_set_wm_maximized(WindowID p_window, bool p_enabled) { | |||
|
|
|||
| XSendEvent(x11_display, DefaultRootWindow(x11_display), False, SubstructureRedirectMask | SubstructureNotifyMask, &xev); | |||
|
|
|||
| if (p_enabled && window_is_maximize_allowed(p_window)) { | |||
| if (p_enabled) { | |||
| window_is_maximize_allowed(p_window); | |||
There was a problem hiding this comment.
Hi! window_is_maximize_allowed returns a bool on whether it can be done and that's it, so I'm not really sure that calling it standalone makes any sense.
I can't find any meaningful side-effect in that method in the X11 implementation either, so I think that you're pretty much removing it from the condition and that's it, which isn't very useful.
Why are you changing this part? I'm not really sure how this is related to the splash.
There was a problem hiding this comment.
ya i should have just removed it from the if... works.
Main::setup2 sets the resolution and then draws the splash...
this i guess adds an extra delay between? idk
There was a problem hiding this comment.
this i guess adds an extra delay between? idk
I think it... shouldn't? It's all done in the main thread I think.
Not really sure what's going on 🤷
Perhaps someone more experienced with the X11 backend could help.
There was a problem hiding this comment.
ya i guess the underlying problem is maybe that _window_maximize_check always returns false (on wayland?) and idk how to fix... so i just cut it out
There was a problem hiding this comment.
I think that this might be some XWayland quirk. It looks oddly familiar to #80036 so perhaps it could be a good starting point, although from a quick glance we might already be using EWMH for _window_maximize_check. Not sure though.
Either way, I'm not sure that completely disabling such a condition because of XWayland is a good idea, especially as we're going to get soon (4.3) a proper native Wayland backend.
Does window_is_maximize_allowed work at all on XWayland?
rakkarage
force-pushed
the
x11-splash-resize
branch
from
b0a6fa0 to
51aa5eb
Compare
#83693
This fix is probably wrong but it seems to work... called twice first time waits 50 attempts second times waits ~3 attempts