Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blender importer adds long suffix to root node name #84025

Closed
rcorre opened this issue Oct 26, 2023 · 6 comments · Fixed by #84678
Closed

Blender importer adds long suffix to root node name #84025

rcorre opened this issue Oct 26, 2023 · 6 comments · Fixed by #84678

Comments

@rcorre
Copy link
Contributor

rcorre commented Oct 26, 2023

Godot version

4.2.beta.custom_build.50d17f6b8

System information

Linux 6.5.8-arch1-1

Issue description

Root nodes of files imported using the blender importer have a hash after the name, e.g. Character-e1c248ae26fc8808362fd6c8fbab07b3. I don't have the same issue with a .glb import of the same file.

Steps to reproduce

  1. Open the project
  2. Open the blend file in Godot
  3. Note the root name has a long suffix
  4. Open the .glb file
  5. Note the root name does not have a long suffix

Minimal reproduction project

example.zip

@Shigewara
Copy link

Have same issue on 4.2 Beta 3 on Windows 10 x64

@rcorre
Copy link
Contributor Author

rcorre commented Nov 3, 2023

As a workaround, you can set RootName in the import options.

@fire
Copy link
Member

fire commented Nov 6, 2023

Looking into it

@akien-mga
Copy link
Member

akien-mga commented Nov 9, 2023

I wrongly assumed that this would be a regression, I checked in earlier dev snapshots and in 4.0-stable, 4.1-stable and 4.1.3-stable, they all behave the same. So it's not critical for the 4.2 release.

Edit: My bad, I was checking the advanced importer and not instantiating the scenes. The problem is with the name of the root node of the instantiated scene. There is indeed a regression there.

In all Godot versions, the advanced importer looks similar:

image

The MeshData has the hash in all Godot versions, unlike the .glb.

What changed recently is that the scene root seems to take its name from the mesh data.

In 4.2-beta5:

image

In 4.1.3-stable:

image

@akien-mga akien-mga modified the milestones: 4.2, 4.x Nov 9, 2023
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Nov 9, 2023
@akien-mga
Copy link
Member

Tested intermediate 4.2 dev/beta snapshots.

The regression was introduced in 4.2-dev5 (dev4 doesn't have the bug).

Didn't bisect further but #80272 sounds possibly related, CC @aaronfranke.

@aaronfranke
Copy link
Member

This was caused by #79774, not #80272. I opened #84678 to fix this, and did a thorough investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment