Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV file that contains a key with underscore which is in between other keys fails to load and crashes. #89571

Closed
Kakiroi opened this issue Mar 16, 2024 · 0 comments · Fixed by #89573
Closed

CSV file that contains a key with underscore which is in between other keys fails to load and crashes. #89571

Kakiroi opened this issue Mar 16, 2024 · 0 comments · Fixed by #89573
Labels
bug confirmed crash regression topic:editor topic:import
Milestone
4.3

Comments

@Kakiroi
Copy link

Kakiroi commented Mar 16, 2024

Tested versions

Godot v4.3.dev5, Godot v4.3.dev3

System information

Godot v4.3.dev5 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 SUPER (NVIDIA; 31.0.15.3699) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)

Issue description

Csv file that contains a key with underscore which is in between other keys fails to load and crashes.

Steps to reproduce

Try to load csv file that contains a key with underscore(_data). That key needs to be in between other keys(en,_data,es).

Minimal reproduction project (MRP)

csvtranslationloaderror.zip
@Kakiroi Kakiroi changed the title Csv file that contains a key with underscore which is inbetween other keys fails to load and crashes. Csv file that contains a key with underscore which is in between other keys fails to load and crashes. Mar 16, 2024
@timothyqiu timothyqiu mentioned this issue Mar 16, 2024
Merged
@akien-mga akien-mga added this to the 4.3 milestone Apr 7, 2024
@akien-mga akien-mga changed the title Csv file that contains a key with underscore which is in between other keys fails to load and crashes. CSV file that contains a key with underscore which is in between other keys fails to load and crashes. Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed crash regression topic:editor topic:import
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix crash when columns are skipped in CSV translation timothyqiu/godot
4 participants
@timothyqiu @akien-mga @AThousandShips @Kakiroi