Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when columns are skipped in CSV translation #89573

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

timothyqiu
Copy link
Member

Fixes #89571

#83600 added locale skipping, but the index used was not adjusted accordingly.

@jsjtxietian
Copy link
Contributor

My bad, thanks!

@timothyqiu timothyqiu requested a review from akien-mga April 7, 2024 09:29
@akien-mga akien-mga changed the title Fix crash when columns are skipped in csv translation Fix crash when columns are skipped in CSV translation Apr 8, 2024
@akien-mga akien-mga merged commit bfccd57 into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the hop branch April 8, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV file that contains a key with underscore which is in between other keys fails to load and crashes.
3 participants