Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descriptions for theme overrides appear only once #90395

Closed
KoBeWi opened this issue Apr 8, 2024 · 0 comments · Fixed by #90446
Closed

Descriptions for theme overrides appear only once #90395

KoBeWi opened this issue Apr 8, 2024 · 0 comments · Fixed by #90446
Labels
bug regression topic:editor
Milestone
4.3

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Apr 8, 2024

Tested versions

Bugged
4.3 dev5
4.2.1

Works
4.1.1

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

godot.windows.editor.dev.x86_64_2iqaz7ACQZ.mp4

Steps to reproduce

  1. Add any Control with theme properties
  2. Go to theme overrides section in the inspector
  3. Hover some property
  4. Unselect and select again the node
  5. Hover the property again
  6. No dESCRIPTIon AvAilABLe

Minimal reproduction project (MRP)

N/A
@KoBeWi KoBeWi added this to the 4.3 milestone Apr 8, 2024
@aaronp64 aaronp64 mentioned this issue Apr 9, 2024
Merged
@KoBeWi KoBeWi mentioned this issue Apr 15, 2024
Merged
divshekhar pushed a commit to divshekhar/godot that referenced this issue Apr 23, 2024
@aaronp64 @divshekhar
Fix theme_override tooltip caching
3dca1f0 
theme_override properties have some special handling in EditorInspector.  When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use.  This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting.  Added theme_item_name to caching to fix this.

Fixes godotengine#90395
theromis pushed a commit to theromis/godot that referenced this issue Apr 29, 2024
@aaronp64 @theromis
Fix theme_override tooltip caching
b94a909 
theme_override properties have some special handling in EditorInspector.  When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use.  This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting.  Added theme_item_name to caching to fix this.

Fixes godotengine#90395
dimitry- pushed a commit to AndroidWasm/godot that referenced this issue May 16, 2024
@aaronp64 @dimitry-
Fix theme_override tooltip caching
04e560a 
theme_override properties have some special handling in EditorInspector.  When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use.  This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting.  Added theme_item_name to caching to fix this.

Fixes godotengine#90395
MewPurPur pushed a commit to MewPurPur/godot that referenced this issue Jul 11, 2024
@aaronp64 @MewPurPur
Fix theme_override tooltip caching
8d949b6 
theme_override properties have some special handling in EditorInspector.  When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use.  This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting.  Added theme_item_name to caching to fix this.

Fixes godotengine#90395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix theme_override tooltip caching aaronp64/godot
2 participants
@KoBeWi @dalexeev