Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One-click deploy to web visible in new projects (without export setup) #91981

Closed
clayjohn opened this issue May 15, 2024 · 2 comments · Fixed by #92032
Closed

One-click deploy to web visible in new projects (without export setup) #91981

clayjohn opened this issue May 15, 2024 · 2 comments · Fixed by #92032

Comments

@clayjohn
Copy link
Member

Tested versions

Slightly out of date master (c4279fe)

System information

All systems

Issue description

The one click deploy button for web export is always available even when the export is not set up. This is visible even in a new project even though its not functional.

image

The button should only appear when a web export is set up and set to "runnable"

Steps to reproduce

Create a new project

Minimal reproduction project (MRP)

web-export-bug.zip

@akien-mga
Copy link
Member

Indeed, I was about to report this too.

See #35592 for context of last time we had this behavior and fixed it. I couldn't quickly find which PR fixed it for context, but there should also be one for Android / starting adb that can be used for reference.

Basically if there's no configured preset for the platform, we should return early.

@matheusmdx
Copy link
Contributor

Bisecting points to #91369 as the culprit:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Critical
Development

Successfully merging a pull request may close this issue.

4 participants