Add more Remote Debug options to the web platform #91369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
approved these changes
May 1, 2024
AThousandShips
approved these changes
May 1, 2024
adamscott
force-pushed
the
web-remote-debug
branch
from
40c9460 to
360c6ed
Compare
|
Thanks @AThousandShips! |
adamscott
force-pushed
the
web-remote-debug
branch
from
360c6ed to
51d2ebf
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (great) quality of life improvements for the web platform for the Remote Debug options.
It may not seem important changes, but iterating on a web project with the old options were... irritating to say the least.
Before, you had to open up a window each time you did changes to the project. This is highly unpractical, since opened browser windows can have the developer tools opened. Opening a new window makes it awkward since it opens without that said window.
Now, you can re-export without even having to close the server. And let say that you have your browser window already opened up before you opened Godot. Now, you can launch the server without opening new windows.
Magical. Extraordinary!
This PR also cleans up
EditorExportPlatformWeb, it could even serve as a template to make theEditorExportPlatformclasses more readable. Instead of countingmenu_optionsand incrementing the values for weird reasons, this uses a small state machine instead.This PR makes it easier too to add new options to the menu, as actions were distinguished from the
run()method.