PackedByteArray resource compression not triggered by sub-resources

[eswartz]

Tested versions

• Reproducible in 4.3 beta 1 and master 96a386f

System information

Godot v4.3.beta.mono (e2e6a4d2b) - Debian GNU/Linux trixie/sid trixie - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 Ti (nvidia) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)

Issue description

The release notes mention PackedByteArray encoding in text resources (https://godotengine.org/article/dev-snapshot-godot-4-3-beta-1/#packedbytearrays-saved-with-base64-encoding), but it doesn't activate for me in certain cases.

I'm not sure this is easy to do without a @tool script which can create nested sub-resources with large data arrays, but that's what I was doing when I ran into this. I.e. I have in-editor scripts that generate Images based on chunks of data and store them in fields of nodes of the scene.

It seems from examining the code that #90889 may be responsible (and may go away later, according to #90889 (review)). It tries to avoid resource incompatibility situations by only triggering compression for large-ish arrays, but contents of variants embedded in sub-resources are not scanned directly, thus missing large arrays that may still be part of the same .tscn file.

Steps to reproduce

To repro:

• open the project in the editor
• look at the 3D view
• confirm a sprite appears
• save the project
• check the fmt_test.tscn file on disk. Should be much less than 14 megs in size.

Minimal reproduction project (MRP)

fmttest.zip

[KoBeWi]

Another related case is var_to_str().

[timothyqiu]

This is caused by a bug when handling PROPERTY_USAGE_RESOURCE_NOT_PERSISTENT (which is only used by ImageTexture 🤣 ).

Would be fixed by #90902.

[eswartz]

This is caused by a bug when handling PROPERTY_USAGE_RESOURCE_NOT_PERSISTENT (which is only used by ImageTexture 🤣 ).

Would be fixed by #90902.

Ah good. Yes, that PR works for me.