Fix error when saving nested non-persistent resource #90902
+1
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug when tweaking the resource format saver.
If a property is
PROPERTY_USAGE_RESOURCE_NOT_PERSISTENT
and is a resource containing another new resource, saving the scene / resource will fail:In the engine, only
ImageTexture*
hasPROPERTY_USAGE_RESOURCE_NOT_PERSISTENT
properties. And those properties don't have nested resource, thus won't trigger this bug.Fixes #92820
To reproduce this bug, use this MRP (test-4.zip).
new_resource.tres
in the inspector.