Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting warnings on startup #96769

Closed
KoBeWi opened this issue Sep 9, 2024 · 4 comments · Fixed by #96780
Closed

Setting warnings on startup #96769

KoBeWi opened this issue Sep 9, 2024 · 4 comments · Fixed by #96780

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 9, 2024

Tested versions

4.4 27552a2
Does not appear in 4.3

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

Every time I open project I see these warnings:

WARNING: Property not found: xr/openxr/enabled.editor
WARNING: EditorSettings::_get - Property not found: asset_library/available_urls
WARNING: EditorSettings::_get - Property not found: _script_setup_templates_dictionary

The first one is weird, because the condition checking for setting looks wrong and the setting itself is never defined.
The others seem to appear when settings are being loaded, which makes no sense.

Steps to reproduce

  1. Open Godot (either project manager or editor)

Minimal reproduction project (MRP)

N/A

@matheusmdx
Copy link
Contributor

Bisecting points to #78656 as the culprit, @Repiteo

image

Godot Engine v4.4.dev.custom_build.9853a6914 (2024-09-04 15:27:26 UTC) - https://godotengine.org
OpenGL API 3.3.0 Core Profile Context 24.7.1.240618 - Compatibility - Using Device: ATI Technologies Inc. - AMD Radeon RX 580 2048SP

WARNING: EditorSettings::_get - Property not found: asset_library/available_urls
     at: EditorSettings::_get (editor\editor_settings.cpp:224)
WARNING: EditorSettings::_get - Property not found: _script_setup_templates_dictionary
     at: EditorSettings::_get (editor\editor_settings.cpp:224)
WARNING: EditorSettings::_get - Property not found: metadata/script_setup_templates_dictionary
     at: EditorSettings::_get (editor\editor_settings.cpp:224)

@akien-mga akien-mga moved this from Unassessed to Immediate Blocker in 4.x Release Blockers Sep 10, 2024
@bruvzg
Copy link
Member

bruvzg commented Sep 10, 2024

Seems to be triggered during loading of editor_settings-4.4.tres (removing the file only temporary fixes it until it is recreated).

@akien-mga
Copy link
Member

The first one is weird, because the condition checking for setting looks wrong and the setting itself is never defined.

It is defined here:

modules/openxr/openxr_api.cpp
276:                    return GLOBAL_GET("xr/openxr/enabled.editor");

@bruvzg
Copy link
Member

bruvzg commented Sep 10, 2024

The first one seems to be unregistered at all, for the rest, loader is trying to match dictionary (and array, but I guess none of the editor settings are arrays) type with default value, but since editor settings have settings registered dynamically, there's no default at the load time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Immediate Blocker
Development

Successfully merging a pull request may close this issue.

4 participants