Add support for specifying ImageFormatLoader Resource import
#100538
+43
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
changed the title
ImageFormatLoader Resource import
Spartan322
force-pushed
the
add/image-import-control
branch
from
2297fd2 to
66cb4e8
Compare
Spartan322
force-pushed
the
add/image-import-control
branch
from
66cb4e8 to
93ba41a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #99666
In attempt to solve #69085 (comment) I tried improving #99666 according to #99666 (comment), this would enable more fine control over resource types in the case the
resource_typestring is specified, which now happens for every Image-releated resource importer. This also doubles up protecting therecognizemethod from letting two resources of a file that share the same extension from interfering with each other which may be a minor concern, though that happening seems unintended and more likely to only happen as a bug.