Patch navigation map async synchronization #100823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
patch_async_mapsync
branch
from
5cb33be to
3caac92
Compare
Patches navigation map async synchronization.
smix8
force-pushed
the
patch_async_mapsync
branch
from
3caac92 to
c694081
Compare
akien-mga
approved these changes
Dec 26, 2024
kiroxas
approved these changes
Dec 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches navigation map async synchronization.
Fixes regression from the two mega PRs #100497 and #100129.
Fixes #100769
Also fixes old bugs encountered in the search process unrelated to the PRs.
Between slicing my own mega branch into 2+ PRs and all the branch rebase and applying foreign changes new bugs and typos slipped in. In the end it was just too much chaos that made isolating the bug sources near impossible. I had to start basically from branch zero applying everything from those 2 PRs again step by step. That is why this PR changes some smaller parts back to the old code style and removes some minor internal things that we agreed in the review but actually caused new and unforeseen bugs.
I tested this PR for days to confirm that all known bugs and regressions are fixed caused by those 2 mega PRs while keeping all the actual changes and improvements. So calm your reviews because I don't want to risk changing anything again before this is merged. As such prefer to merge this as is asap. If we want to change something we should do it after this PR has been merged.