Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a segfault handler to dump the backtrace on Windows, Linux and OS X #11061

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

marcelofg55
Copy link
Contributor

Same as #10124 but for 3.0

@hpvb
Copy link
Member

hpvb commented Sep 8, 2017

This should probably default to on in SCons with an option to turn it off. Some of the issues I've fixed for people on IRC would've been so much faster if we didn't first have to teach them to use gdb.

@marcelofg55
Copy link
Contributor Author

@hpvb Yeah, this will help reporting crashes for people that don't know gdb. Also I think it can be handy for random crashes too.
The option on SCons was discussed over #10124, @akien-mga decided it was better to have a --disable-backtrace on this instead of a SCons option, since anyways gdb has priority over this handler when debugging.

@marcelofg55 marcelofg55 force-pushed the dump_backtrace branch 2 times, most recently from 81a032b to 93d577e Compare September 8, 2017 12:09
@hpvb
Copy link
Member

hpvb commented Sep 12, 2017

This looks great, one thing: Could you add documentation for --disable-backtrace to the --help documentation in main/main.cpp?

@marcelofg55 marcelofg55 force-pushed the dump_backtrace branch 3 times, most recently from 8602b0c to 679bfb6 Compare September 13, 2017 02:45
@marcelofg55
Copy link
Contributor Author

I've changed the --disable-backtrace to --disable-crash-handler and moved the crash handler code to its own .cpp/.h on each platform.

@hpvb
Copy link
Member

hpvb commented Sep 13, 2017

Just some small clang-format errors now, and it seems that the iPhone platform won't build now. Maybe check to see if similar issues now exist for html5?

@marcelofg55 marcelofg55 force-pushed the dump_backtrace branch 2 times, most recently from 4cbf3e2 to 83fe937 Compare September 13, 2017 13:02
@marcelofg55
Copy link
Contributor Author

Rebased and fixed that iPhone platform compile error, should be good on html5 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants