Allow to extends constant variable(master) #12507
Conversation
| StringName identifier = tokenizer->get_token_identifier(); | ||
| p_class->extends_class.push_back(identifier); | ||
| } | ||
| break; |
There was a problem hiding this comment.
It looks like clang-format doesn't like the indentation style you used: https://travis-ci.org/godotengine/godot/jobs/294820735
|
Pre-approved in PR review meeting, will merge tomorrow once 3.0 alpha2 is released, to avoid potential regressions. |
| if (base_class->subclasses.has(subclass)) { | ||
|
|
||
| base_class = base_class->subclasses[subclass]; | ||
| } else if (base_class->constants.has(subclass)) { | ||
|
|
||
| Ref<GDScript> base = base_class->constants[subclass]; |
There was a problem hiding this comment.
You are overloading your outer scope variable String base here and I don't think it's a good practice. Try using some different name, for example Ref<GDScript> new_base_class would be better imho.
|
Sorry for the delay - I've done a refactoring of the gdscript module in #12969 so there are now merge conflicts to resolve. As the file names changed and all |
this pr same to : #12506