Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed build failing because of unset defines #13

Closed
wants to merge 1 commit into from
Closed

Fixed build failing because of unset defines #13

wants to merge 1 commit into from

Conversation

codecat
Copy link
Contributor

@codecat codecat commented Feb 10, 2014

These lines seem to be missing from SConstruct.

@godotengine
Copy link
Collaborator

Windows detection is on platform/windows/detect.py
I haven't compiled using MSVC in a while, but if you check that file, there is a big if that detects between MSVC command prompt and MINGW command prompt, the flags are likely missing in the MSVC version. I tried to fix them and pushed a new version, can you tell me if my changes fix it? (i have no way to test here)

@codecat
Copy link
Contributor Author

codecat commented Feb 10, 2014

Ah, gotcha. Somehow missed that. Going to try it now.

@codecat
Copy link
Contributor Author

codecat commented Feb 10, 2014

Seems to have fixed it, thanks. Feel free to close this pull request :)

@marynate
Copy link
Contributor

There're still plenty:
LNK2005: _FT_xxx already defined in freetype_builtin2.lib
when linking with VS

It' can be override with
env.Append(LINKFLAGS=['/FORCE:MULTIPLE'])
but not ideal

@reduz
Copy link
Member

reduz commented Feb 14, 2014

seems this was fixed by anoher patch

@reduz reduz closed this Feb 14, 2014
@reduz reduz mentioned this pull request May 11, 2014
Closed
This was referenced Jan 16, 2015
Closed
Closed
@slapin slapin mentioned this pull request Feb 3, 2015
Closed
@reduz reduz mentioned this pull request Mar 22, 2015
Closed
@draxdeveloper draxdeveloper mentioned this pull request Aug 31, 2015
Closed
@AlexHolly AlexHolly mentioned this pull request Apr 18, 2016
Closed
@wombatstampede wombatstampede mentioned this pull request Apr 4, 2017
Closed
@eon-s eon-s mentioned this pull request Aug 16, 2017
Closed
@supagu supagu mentioned this pull request Aug 27, 2017
Closed
@tofuhead tofuhead mentioned this pull request Sep 13, 2017
Closed
@alexzheng alexzheng mentioned this pull request Sep 27, 2017
Closed
hungrymonkey referenced this pull request in hungrymonkey/godot Sep 30, 2017
@slomkowski
Merge pull request jcalifornia#13 from Hunter522/swap64-fix
c5fc079 
Fix SWAP64 implementation to work on more platforms
@Alexia-AT-Digitecnology Alexia-AT-Digitecnology mentioned this pull request Oct 19, 2017
Closed
@shakenov-chinga shakenov-chinga mentioned this pull request Dec 3, 2017
Closed
@reduz reduz mentioned this pull request Dec 17, 2017
Closed
@kakoeimon kakoeimon mentioned this pull request Dec 18, 2017
Closed
@gattila gattila mentioned this pull request Dec 22, 2017
Closed
@Outrider0x400 Outrider0x400 mentioned this pull request Mar 2, 2018
Merged
@xfactor2000 xfactor2000 mentioned this pull request Jun 8, 2018
Closed
@GatoAmarilloBicolor GatoAmarilloBicolor mentioned this pull request Jul 9, 2018
Closed
@lukaszbulzacki lukaszbulzacki mentioned this pull request Jul 16, 2018
Closed
@slapin slapin mentioned this pull request Jul 24, 2018
Closed
@akien-mga akien-mga mentioned this pull request Aug 26, 2018
Closed
@spongeboburu spongeboburu mentioned this pull request Oct 15, 2018
Closed
@GatoAmarilloBicolor GatoAmarilloBicolor mentioned this pull request Nov 8, 2018
Closed
@GatoAmarilloBicolor GatoAmarilloBicolor mentioned this pull request Dec 27, 2018
Closed
@psoslash psoslash mentioned this pull request Feb 28, 2019
Closed
@ProbDenis ProbDenis mentioned this pull request Mar 12, 2019
Closed
@Tobi-La Tobi-La mentioned this pull request Mar 12, 2019
Closed
@SMaiLubis SMaiLubis mentioned this pull request May 8, 2019
Closed
@fian46 fian46 mentioned this pull request Jan 22, 2020
Closed
@JezSonic JezSonic mentioned this pull request Apr 20, 2020
Closed
@MightyPrinny MightyPrinny mentioned this pull request Apr 21, 2020
Closed
@EricEzaM EricEzaM mentioned this pull request May 23, 2020
Closed
@Darkheron Darkheron mentioned this pull request Oct 26, 2020
Closed
@alexzheng alexzheng mentioned this pull request Jan 21, 2021
Closed
@sunnydrake sunnydrake mentioned this pull request Mar 15, 2021
Closed
@akien-mga akien-mga mentioned this pull request Jul 7, 2021
Merged
@rockgem rockgem mentioned this pull request Nov 2, 2021
Closed
@YACO99 YACO99 mentioned this pull request Nov 27, 2021
Closed
@qarmin qarmin mentioned this pull request Oct 2, 2022
Open
@Flynsarmy Flynsarmy mentioned this pull request Oct 12, 2022
Closed
@norrath-hero-cn norrath-hero-cn mentioned this pull request Dec 19, 2022
Closed
@norrath-hero-cn norrath-hero-cn mentioned this pull request Jan 26, 2023
Closed
lawnjelly added a commit to lawnjelly/godot that referenced this pull request Mar 31, 2023
@lawnjelly
Merge pull request godotengine#13 from lawnjelly/plus_static_checks
49dc855 
Fix static checks
@DrRevert DrRevert mentioned this pull request Apr 8, 2023
Open
Ansraer pushed a commit to Ansraer/godot that referenced this pull request May 9, 2023
@hpvb
Merge pull request godotengine#13 from YeldhamDev/java_home_hardcode_fix
1fc8b51 
Add envs to allow using the system's tooling
@MileyHollenberg MileyHollenberg mentioned this pull request Jul 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecat @godotengine @marynate @reduz