Allow degenerate triangles in polygon triangulation when necessary. #17129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17102.
This modifies the ear-clipping implementation so that it first tries to avoid completely flat triangles, but falls back to allowing them as a last resort when triangulation would otherwise fail.
I explained this with a few more details on the issue.
This adds a bit of unfortunate branchiness that hurts code aesthetics more than actual performance, because these branches are very predictable and ear clipping is already pretty inefficient anyway.
If we don't care about degenerate triangles at all, we can replace this change by simply turning the first check in
Triangulate::snip
into:Using a negative epsilon instead of zero conservatively avoids potential floating point precision issues.