Batch GLES2 draw calls #20965
Batch GLES2 draw calls #20965
Conversation
dragmz
force-pushed
the
gles2_batching
branch
2 times, most recently
from
4552f1d
to
dafe97b
Compare
drivers/gles2/shader_gles2.cpp
Outdated
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
Maybe you could just have:
return (active != this || !version || new_conditional_version.key != conditional_version.key);
(Just a very little thing in what looks like a really great PR, can't wait to see the speedup)
There was a problem hiding this comment.
Thanks for catching this code smell, I'll clean it up.
Adds GLES2 draw calls batching for the same render list item that uses multiple rasterizer commands (e.g. Label node; a node with multiple GDScript draw_* calls).
|
Looks good to me, @karroffel ? |
| buffer[(3 * 4 * 4) + 14] = (source.position.x + source.size.x) * texpixel_size.x; | ||
| buffer[(3 * 4 * 4) + 15] = (source.position.y + source.size.y) * texpixel_size.y; | ||
| const bool p_singlecolor = pline->triangle_colors.size() == 1; | ||
| const Color *p_colors = pline->triangle_colors.ptr(); |
There was a problem hiding this comment.
Those two shouldn't have a p_ as a prefix, since those are used for parameters, not local variables. Also p_singlecolor is unused.
| if (pline->triangles.size()) { | ||
| const int p_vertex_count = pline->triangles.size(); | ||
| const int p_triangle_count = p_vertex_count - 2; | ||
| const int p_index_count = p_triangle_count * 3; |
There was a problem hiding this comment.
All those shouldn't have the p_ prefix. In Godot's naming convention we use that only for parameter declarations, not local variables. This happens in multiple places, but it's actually not a big deal and doens't block this PR in the slightest :)
|
Just mentioning here for clarity that this was reverted in #21204. |
Fixes #19917
Adds GLES2 draw calls batching for the same render list item that uses
multiple rasterizer commands (e.g. Label node; a node with multiple
GDScript draw_* calls).
This does not cover glBufferSubData calls batching that I've tried to fix in #20077.
Some stats for the number of draw calls -
Before:
After: