Fixed floating point issue in find() of animation. #23632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 10, 2018
scene/resources/animation.cpp
Outdated
| @@ -1469,7 +1469,7 @@ int Animation::_find(const Vector<K> &p_keys, float p_time) const { | |||
|
|
|||
| middle = (low + high) / 2; | |||
|
|
|||
| if (p_time == keys[middle].time) { //match | |||
| if (Math::absf(p_time - keys[middle].time) < CMP_EPSILON) { //match | |||
There was a problem hiding this comment.
You can use Math::abs directly, I don't think absf and absd are meant to be used directly.
There was a problem hiding this comment.
I'm confused, Math::absf is used a bunch in this file, see line 1704, 1718, 1675...
There was a problem hiding this comment.
That's probably by oversight, Math::abs already calls Math::absf or Math::absd internally, so unless you want to make 100% that it will be float and never double, Math::abs should be used.
$ rg "Math::abs[^df]" | wc -l
145
$ rg "Math::abs[df]" | wc -l
14
|
Thanks! |
|
Thanks so much guys for a quick resolution. This one has been a thorn in our side lately. |
|
I've added this to #18992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23504