Fixing Button text ignores breakline (\n) #2967 #24374
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we add a \ n or \ t directly in the editor or add \ t to GDScript, those characters are either printed or discarded and have no effect. This happen is because if the string contains '\ n', Variant object stores two printable characters '\' and 'n'. So just check the string and change the characters '\' 'n' and '\' 't' to '\ n' and '' (4 spaces). For this was added a method to the String class, check_control_characters, which does this verification. And this method is called in the Control::get_tooltip. Fixing #2967 Button text ignores breakline (\n)
When we add a \ n or \ t directly in the editor or add \ t to GDScript, those characters are either printed or discarded and have no effect. To fix this it was enough to call the check_control_characters method of the class String in the methods Label::set_text and Label::get_text. Fixing #2967 Button text ignores breakline (\n)
When we add a \ t directly in the editor or in the GDScript, those characters are either printed or discarded and have no effect. To fix this it was enough to call the check_control_characters method of the class String in the methods Button::set_text and Button::get_text. Fixing #2967 Button text ignores breakline (\n)
StraToN
previously requested changes
Dec 18, 2018
Clearing commented and unneeded code lines
|
@cesarpinho Please fix the conflicts. |
| String str_begin = s.substr(0, tab_pos); | ||
| String str_end = s.substr(tab_pos + 1, s.length()); | ||
|
|
||
| s = str_begin + " " + str_end; |
There was a problem hiding this comment.
Should we always assume, that \t == 4 spaces? Shouldn't it be configurable per usecase?
|
@cesarpinho Requesting rebase. |
|
@cesarpinho The merges you pushed aren't the same as a rebase. Godot requires contributors to make their PRs have good Git history in order to be accepted. Please see this article for more information: https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html |
|
@cesarpinho Requesting rebase and squash. |
|
This PR has not been in a good state for about a year, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a long review of the code, the discussion on the issue #2967 page and the other merged issues (#4327 and #21334), I present a solution proposal.
In this comment, @StraToN say :
And that's what I did. I fix the tabs in the Buttons' captions, Labels text and Control tooltips and fix the line breaks in the Label text and Control tooltip.
Before
After
Fix #2967