fix CustomType error spams in CreateDialog #25675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnationsdev
force-pushed
the
fix-customtype-errorspam
branch
from
27e7a50 to
ca771a7
Compare
YeldhamDev
reviewed
Feb 7, 2019
willnationsdev
force-pushed
the
fix-customtype-errorspam
branch
from
ca771a7 to
80c70b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #24041. It adds a bunch of logic to account for CustomTypes in the various checks it performs.
It should be noted that the CreateDialog's inheritance and type checking is becoming increasingly complex, so this solution is more of a bandaid. If/when something like #22181 is integrated, allowing scenes to be named entities as well, then there'll be all the more need for something like the ClassType module it includes to greatly simplify all of the logic.