-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure classes match their header filename #25821
Ensure classes match their header filename #25821
Conversation
Also drop some unused files. Renamed: - `core/dvector.h` -> `pool_vector.h` - `core/io/resource_import.h` -> `resource_importer.h` - `core/sort.h` -> `sort_array.h` - `core/string_db.h` -> `string_name.h` Dropped: - `core/allocators.h` - `core/os/shell.h` - `core/variant_construct_string.cpp`
@akien-mga Added to my working copy of the changelog 🙂 I guess I'll send another PR before the 3.1 release. |
Renamed: - `drivers/alsamidi/alsa_midi.h` -> `midi_driver_alsamidi.h` (same for `coremidi` and `winmidi`) - `main/timer_sync.h` -> `main_timer_sync.h` - `servers/visual/visual_server_global.h` -> `visual_server_globals.h`
c9ae931
to
b1b3b59
Compare
Also drop some unused files. Renamed: - `platform/iphone/sem_iphone.h` -> `semaphore_iphone.h` (same for `osx`) - `platform/uwp/gl_context_egl.h` -> `context_egl_uwp.h` - in `platform/windows`: `context_gl_win.h`, `crash_handler_win.h`, `godot_win.cpp`, `joypad.h` and `key_mapping_win.h` all renamed to use `windows`. Some classes renamed accordingly too. - `EditorExportAndroid` and `EditorExportUWP` renamed to `EditorExportPlatformAndroid` and `EditorExportPlatformUWP` - `power_android` and `power_osx` renamed to `PowerAndroid` and `PowerOSX` - `OSUWP` renamed to `OS_UWP` Dropped: - `platform/windows/ctxgl_procaddr.h`
b1b3b59
to
bc26d0d
Compare
Also drop some unused files. Renamed: - `scene/2d/navigation2d.h` -> `navigation_2d.h` - `scene/2d/screen_button.h` -> `touch_screen_button.h` - `scene/3d/scenario_fx.h` -> `world_environment.h` - `scene/audio/audio_player.h` -> `audio_stream_player.h` - `scene/resources/bit_mask.h` -> `bit_map.h` - `scene/resources/color_ramp.h` -> `gradient.h` - `scene/resources/shape_line_2d.h` -> `line_shape_2d.h` - `scene/resources/scene_format_text.h` -> `resource_format_text.h` - `scene/resources/sky_box.h` -> `sky.h` Dropped: - `scene/resources/bounds.h`
b689884
to
c5dcbeb
Compare
Only In |
Done |
Renamed: - `modules/mono/mono_gd/gd_mono_class_member.h` -> `i_mono_class_member.h` - `modules/upnp/upnpdevice.h` -> `upnp_device.h` - `modules/websocket/websocket_multiplayer.h` -> `websocket_multiplayer_peer.h`
8566670
to
fe7e11e
Compare
Might be worth considering "Win32" because UWP is also Windows (10). Though this may be jumping the gun a bit, since I don't think UWP will become the default for at least another decade.
Why not
Wow, I've never seen gradients called "color ramp" before :P |
Don't see much use for renaming it this way, and it would be a massive change (and compat breakage for build scripts).
Most editor classes start with |
Also drop some unused files.
Core
Renamed:
core/dvector.h
->pool_vector.h
core/io/resource_import.h
->resource_importer.h
core/sort.h
->sort_array.h
core/string_db.h
->string_name.h
Dropped:
core/allocators.h
core/os/shell.h
core/variant_construct_string.cpp
Drivers, main, servers
Renamed:
drivers/alsamidi/alsa_midi.h
->midi_driver_alsamidi.h
(same for
coremidi
andwinmidi
)main/timer_sync.h
->main_timer_sync.h
servers/visual/visual_server_global.h
->visual_server_globals.h
Platform
Renamed:
platform/iphone/sem_iphone.h
->semaphore_iphone.h
(same for
osx
)platform/uwp/gl_context_egl.h
->context_egl_uwp.h
platform/windows
:context_gl_win.h
,crash_handler_win.h
,godot_win.cpp
,joypad.h
andkey_mapping_win.h
all renamed touse
windows
. Some classes renamed accordingly too.EditorExportAndroid
andEditorExportUWP
renamed toEditorExportPlatformAndroid
andEditorExportPlatformUWP
power_android
andpower_osx
renamed toPowerAndroid
andPowerOSX
OSUWP
renamed toOS_UWP
Dropped:
platform/windows/ctxgl_procaddr.h
Scene
Renamed:
scene/2d/navigation2d.h
->navigation_2d.h
scene/2d/screen_button.h
->touch_screen_button.h
scene/3d/scenario_fx.h
->world_environment.h
scene/audio/audio_player.h
->audio_stream_player.h
scene/resources/bit_mask.h
->bit_map.h
scene/resources/color_ramp.h
->gradient.h
scene/resources/shape_line_2d.h
->line_shape_2d.h
scene/resources/scene_format_text.h
->resource_format_text.h
scene/resources/sky_box.h
->sky.h
Dropped:
scene/resources/bounds.h
Modules
Renamed:
modules/mono/mono_gd/gd_mono_class_member.h
->i_mono_class_member.h
modules/upnp/upnpdevice.h
->upnp_device.h
modules/websocket/websocket_multiplayer.h
->websocket_multiplayer_peer.h
Might break compat for some thirdparty modules that include e.g.
core/dvector.h
orcore/io/resource_import.h
, would be worth mentioning in the changelog @Calinou.