SCons: Move platform-specific Opus config to its module #26473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Mar 2, 2019
| if env["platform"] == "android" or env["platform"] == "iphone": | ||
| if ("arch" in env and env["arch"] == "arm") or ("android_arch" in env and env["android_arch"] in ["armv6", "armv7"]): | ||
| env_opus.Append(CFLAGS=["-DOPUS_ARM_OPT"]) | ||
| elif ("arch" in env and env["arch"] == "arm64") or ("android_arch" in env and env["android_arch"] == "arm64v8"): |
There was a problem hiding this comment.
The only actual logic change is here: now we're also enabling OPUS_ARM64_OPT on arm64v8 for Android. Previously it has been left out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally fixing this old "TODO".
It's still far from perfect, we enable ARM-specific optimizations but we don't compile the ARM-specific code provided in the thirdparty repo.
But since Opus is on life support and only used by the Webm module, I don't want to spend too much effort on it. We should probably consider dropping it (and thus dropping Opus support in Webm), or find a way to address #7496 and re-enable Opus support as AudioStream.