Fix navmesh not finding optimal paths #28640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 3, 2019
Addresses part of godotengine#17885
bojidar-bg
force-pushed
the
17885-navmesh-entry-broken
branch
from
0067d4a
to
f1b7b74
Compare
akien-mga
reviewed
May 3, 2019
| for (int i = 0; i < p->edges.size(); i++) { | ||
|
|
||
| Polygon::Edge &e = p->edges.write[i]; | ||
|
|
||
| if (!e.C) | ||
| continue; | ||
|
|
||
| #ifdef USE_ENTRY_POINT |
There was a problem hiding this comment.
I wonder what's the point of this define since it can't be toggled conditionally. Sounds like we're maintaining dead code in the #else branches.
There was a problem hiding this comment.
It was added in #22047, so I decided to not touch it yet.
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses first point of #17885.
Applies changes from #21492, just in case.
I can confirm that the test project from #17885 works fine with this PR, but I cannot guarantee that the algorithm is fully correct.