Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unneeded c files from the freetype build rules #32

Merged
merged 2 commits into from
Feb 11, 2014

Conversation

bwzuk
Copy link
Contributor

@bwzuk bwzuk commented Feb 11, 2014

Removed unneeded c files from the freetype build rules, to prevent errors compiling under VC. Some files were referenced in the scons rule file, and also #included in c files, resulting in duplicated symbols.

@gamedevsam
Copy link
Contributor

I need this change, it's preventing me from compiling the engine in windows.

@bwzuk
Copy link
Contributor Author

bwzuk commented Feb 11, 2014

It's easy enough to make the change locally. Also see my post in #12

godotengine pushed a commit that referenced this pull request Feb 11, 2014
Removed unneeded c files from the freetype build rules
@godotengine godotengine merged commit 1adc330 into godotengine:master Feb 11, 2014
@godotengine
Copy link
Collaborator

merged! please to anyone else having this issue confirm if it still happens ( I don have Windows with MSVC installed atm)

@draxdeveloper draxdeveloper mentioned this pull request Aug 31, 2015
hungrymonkey referenced this pull request in hungrymonkey/godot Sep 30, 2017
Add some command line parameters to overrule default paths
akien-mga added a commit to akien-mga/godot that referenced this pull request May 19, 2021
We found that this flag causes this error on PR godotengine#48812 which does not add any
fancy inline assembly:
```
/tmp/tile_set-ce236a.s: Assembler messages:
/tmp/tile_set-ce236a.s:34676: Error: selected processor does not support `bfc x0,godotengine#32,godotengine#32'
clang++: error: assembler command failed with exit code 1 (use -v to see invocation)
```

That flag is mentioned in various errors related to assembler failures on
arm64v8 with Clang from the Android NDK.

It was added in Godot in godotengine#6958 when migrating from GCC to Clang, and is indeed
referenced in the NDK's Clang migration guide:
https://android.googlesource.com/platform/ndk/+/master/docs/ClangMigration.md

> Especially for ARM and ARM64, Clang is much stricter about assembler rules
> than GCC/GAS. Use `-fno-integrated-as` if Clang reports errors in inline
> assembly or assembly files that you don't wish to modernize.

We don't get those errors nowadays so it seems the flag is no longer needed.
akien-mga added a commit that referenced this pull request May 19, 2021
We found that this flag causes this error on PR #48812 which does not add any
fancy inline assembly:
```
/tmp/tile_set-ce236a.s: Assembler messages:
/tmp/tile_set-ce236a.s:34676: Error: selected processor does not support `bfc x0,#32,#32'
clang++: error: assembler command failed with exit code 1 (use -v to see invocation)
```

That flag is mentioned in various errors related to assembler failures on
arm64v8 with Clang from the Android NDK.

It was added in Godot in #6958 when migrating from GCC to Clang, and is indeed
referenced in the NDK's Clang migration guide:
https://android.googlesource.com/platform/ndk/+/master/docs/ClangMigration.md

> Especially for ARM and ARM64, Clang is much stricter about assembler rules
> than GCC/GAS. Use `-fno-integrated-as` if Clang reports errors in inline
> assembly or assembly files that you don't wish to modernize.

We don't get those errors nowadays so it seems the flag is no longer needed.

(cherry picked from commit 23f7c75)
akien-mga added a commit that referenced this pull request May 19, 2021
We found that this flag causes this error on PR #48812 which does not add any
fancy inline assembly:
```
/tmp/tile_set-ce236a.s: Assembler messages:
/tmp/tile_set-ce236a.s:34676: Error: selected processor does not support `bfc x0,#32,#32'
clang++: error: assembler command failed with exit code 1 (use -v to see invocation)
```

That flag is mentioned in various errors related to assembler failures on
arm64v8 with Clang from the Android NDK.

It was added in Godot in #6958 when migrating from GCC to Clang, and is indeed
referenced in the NDK's Clang migration guide:
https://android.googlesource.com/platform/ndk/+/master/docs/ClangMigration.md

> Especially for ARM and ARM64, Clang is much stricter about assembler rules
> than GCC/GAS. Use `-fno-integrated-as` if Clang reports errors in inline
> assembly or assembly files that you don't wish to modernize.

We don't get those errors nowadays so it seems the flag is no longer needed.

(cherry picked from commit 23f7c75)
lawnjelly added a commit to lawnjelly/godot that referenced this pull request Apr 25, 2023
2D Physics Interpolation - Lights and Occluders
MisterPuma80 pushed a commit to MisterPuma80/just_a_game_engine that referenced this pull request Oct 18, 2024
…um-dev

Revert "Branding - Add Teki's indigo theme"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants