Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow to export pck without preset #32862

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Don't allow to export pck without preset #32862

merged 1 commit into from
Oct 16, 2019

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 16, 2019 •
edited
Loading

Fixes #24894

Greetings from GodotCon!

@reduz reduz self-requested a review October 16, 2019 09:57
@groud groud added this to the 3.2 milestone Oct 16, 2019
@akien-mga
Copy link
Member

It would be better if this button was a custom one instead of get_ok(), but that's for another PR :)

@akien-mga akien-mga merged commit 119bf23 into godotengine:master Oct 16, 2019
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the exportn branch October 16, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

@reduz reduz reduz approved these changes

@groud groud groud approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Exporting pck/zip fails if no export preset is configured/selected
5 participants
@KoBeWi @akien-mga @groud @reduz @RandomShaper