Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "restore_scenes_on_load" default value to TRUE #33586

Closed

Conversation

Muller-Castro
Copy link
Contributor

As the way Godot is designed, a concept can be fragmented into several scenes that, depending on what's being developed, may take days to finish. Without this option checked one must note the names of scenes being edited somewhere to continue the next day. So it'd be a good idea to leave this option checked by default as it's quite useful and a little hard to find in the editor...

As the way Godot is designed, a concept can be fragmented into several scenes that, depending on what's being developed, may take days to finish. Without this option checked one must note the names of scenes being edited somewhere to continue the next day. So it'd be a good idea to leave this option checked by default as it's quite useful and a little hard to find in the editor...
@AlexHolly
Copy link
Contributor

The reason for this is the long loading time especially in 3D I already have to wait a few seconds in 2D with 2-3 Scenes Open. Even if this would be the new default, this process should get a loading screen first.

@groud
Copy link
Member

groud commented Nov 13, 2019

As @AlexHolly stated, this cannot be done by default. Opening several heavy scenes might cause problems, freezing your computer. So unless we add a way to cancel the opening of a scene, it should not be set on by default.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 13, 2019

If someone's problem is that their project loads long time, just close some scenes before exiting or disable this option. If one has big enough project to come into this issue, they are experienced enough to handle it.

But yeah, #27847 is a problem.

@groud
Copy link
Member

groud commented Nov 13, 2019

If someone's problem is that their project loads long time, just close some scenes before exiting or disable this option. If one has big enough project to come into this issue, they are experienced enough to handle it.

The problem is that in some cases, you might not even be able to reach this point. If you have a problem like not having enough memory, or a scene crashes your software, this might prevent you from opening the project.

This cannot be done by default, unless we add a safeguard for that. This can be either a "cancel" button, or maybe a dialog box when your program did not exit normally to ask whether or not to open scenes again.

But I agree, it would be good to be able to have that by default, but safeguards need to be implemented first.

@Muller-Castro
Copy link
Contributor Author

Good points 👍 So the solution in this case is to use an instance of ResourceInteractiveLoader to open the scenes...

@akien-mga akien-mga added this to the 4.0 milestone Nov 13, 2019
@aaronfranke
Copy link
Member

aaronfranke commented Jul 1, 2020

As noted above, this should be false by default to avoid serious issues, therefore I'm closing this.

(Also, I personally prefer this to be false)

For @Muller-Castro's use case... you can just enable it for yourself, that's why it's an editor setting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants