Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user when trying to free locked references. #33788

Closed
wants to merge 1 commit into from

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Nov 21, 2019

This explains #33279 , #33290 . Demos will need to be fixed too if this is confirmed to be the desired approach.

The reference will not be freed when debug is enabled, causing a memory leak as explained by the message.

Needs review from @reduz : I hope I understood well what you suggested.

@capnm
Copy link
Contributor

capnm commented Nov 25, 2019

👍 Has already caught mistakes in my network script:

E 0:08:35:0245   unreference: Reference is locked and can't be freed. You are leaking memory! This will likely cause crashes in release builds.
  <C++ Error>    Condition ' _is_locked() && die ' is true. returned: false
  <C++ Source>   core/reference.cpp:100 @ unreference()
  <Stack Trace>  Lobby.gd:244 @ server_disconnected()

@qarmin
Copy link
Contributor

qarmin commented Dec 20, 2019

I think that this can be closed because signal checking was (re)added here - 22637be

@Faless
Copy link
Collaborator Author

Faless commented Dec 20, 2019

Yep, closing, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants