Implement safe area on android platform #34537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoFr1ends
force-pushed
the
safe-area-android
branch
2 times, most recently
from
5bcc80d
to
0360f48
Compare
NoFr1ends
force-pushed
the
safe-area-android
branch
2 times, most recently
from
5fd7c44
to
d87caae
Compare
NoFr1ends
force-pushed
the
safe-area-android
branch
from
d87caae
to
aefc5e4
Compare
|
@NoFr1ends Is this still desired? If so, it needs to be rebased on the latest master branch. |
|
I didn’t tracked the changes to the master branch in the recent time, but then the Vulcan branch got merged the Android build was broken and I couldn’t test it again that’s why I didn’t rebased it yet. |
|
That feature got implemented in #43104, so this PR can probably be closed. |
|
Closing per @mbrlabs' comment. Thanks for the contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the
OS.get_window_safe_area()method on android platform having Android 9 or later.Before Android 9 there is no official way to get the safe area.
This changes the default behavior for Android 9 and later!
Without this merge Godot applications in landscape mode would letterbox the display cutout. After this PR Godot uses fullscreen again and the developers have to change their UI to respect the window safe area.
I thought about adding an option to allow the user to specify the
layoutInDisplayCutoutModeand default that to the default value instead ofLAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES. Please give me feedback about this.Feature Proposal: godotengine/godot-proposals#321
This also might fix #34466 depending on if the manufacture added this to the safe area.