Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time scale property to Timer node #34544

Closed

Conversation

wingedadventurer
Copy link
Contributor

@wingedadventurer wingedadventurer commented Dec 22, 2019

Adds time scale property to the Timer node, allowing it to tick faster/slower.

Useful if you are implementing slow motion mechanic, and want specific Timer nodes to behave accordingly (Engine.time_scale won't cut it as it is applied to every node). Think games like Superhot, where game timer can either tick in real-time or in slowmo-time.

@wingedadventurer wingedadventurer requested a review from a team as a code owner December 22, 2019 17:04
@wingedadventurer wingedadventurer changed the title Add time scale property to Timer node (and update docs accordingly) Add time scale property to Timer node Dec 22, 2019
@Chaosus Chaosus added this to the 4.0 milestone Dec 23, 2019
@aaronfranke
Copy link
Member

@wingedadventurer Is this still desired? If so, it needs to be rebased on the latest master branch.

@wingedadventurer wingedadventurer force-pushed the timer-time-scale branch 2 times, most recently from 5be6004 to 376d441 Compare July 3, 2020 18:41
@wingedadventurer wingedadventurer requested a review from a team as a code owner March 3, 2021 14:17
scene/main/timer.cpp Outdated Show resolved Hide resolved
@reduz
Copy link
Member

reduz commented Aug 30, 2021

I don't see a proposal attached to this pull request. Additionally, just using Timer::set_wait_time and multiplying that time for a scale value will result in exactly the same effect, for which adding an extra function looks of little use to me.

I suggest closing it.

@aaronfranke
Copy link
Member

This was discussed on Godot's RocketChat. The consensus is that this change is not necessary as it can be easily worked around, and therefore this PR is not desired. Closing.

@rpahut
Copy link

rpahut commented Apr 25, 2024

Additionally, just using Timer::set_wait_time and multiplying that time for a scale value will result in exactly the same effect, for which adding an extra function looks of little use to me.

Not if you need to engage slow motion and then turn it off, and then on again with a different multiplier, while the timer is ticking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants