Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Vsync Via Compositor project setting #35191

Closed
wants to merge 0 commits into from
Closed

Remove Vsync Via Compositor project setting #35191

wants to merge 0 commits into from

Conversation

hoontee
Copy link
Contributor

@hoontee hoontee commented Jan 16, 2020

Needs testing from users affected by #19783. This most likely doesn't work, but we'll see.

vsync_via_compositor displeases me, so I have removed it.

Compositor syncing is now permanently enabled under the following conditions:

The fix for #35038 is still present.

@hoontee hoontee requested a review from a team as a code owner January 16, 2020 10:05
@hoontee hoontee closed this Jan 16, 2020
@hoontee hoontee reopened this Jan 16, 2020
@akien-mga
Copy link
Member

Please amend the commit log to make it more explicit, "Fix" is definitely not an appropriate commit log in our codebase... See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-logs-with-readability-in-mind

The PR description itself is good, but the commit log should follow the same standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants