Fix HTML5 one click button being active with templates missing #35680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2020 01:47
The editor would previously have the HTML5 one click deploy button is always visible if an HTML5 preset has been defined, even if the templates are missing or if it's misconfigured. This disables the button in these cases and provides the error message output of can_export as the tooltip of the disabled button. Fixes #35592.
YeldhamDev
added
the
cherrypick:3.x
KoBeWi
reviewed
Jan 10, 2022
| } | ||
|
|
||
| if (preset.is_null()) { | ||
| menus[i]->set_disabled(true); |
There was a problem hiding this comment.
This will crash if menus[i] is null (which might be possible, considering the code in ENTER_TREE). You need to add a null check.
|
The issue mentions #35570, which is no longer needed after this change. The button will be disabled if the template is invalid, so there is no way to trigger that bug. (I didn't test though) |
ghost
closed this
ghost
deleted the
akien-mga
added
archived
and removed
cherrypick:3.x
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor would previously have the HTML5 one click deploy button is always visible if an HTML5 preset has been defined, even if the templates are missing or if it's misconfigured.
This disables the button in these cases and provides the error message output of can_export as the tooltip of the disabled button.
Fixes #35592.
This is my first attempt at a change on this project - if anything is wrong, apologies, please let me know.