Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes enum autocompletetion showing class names with an underscore #35739

Closed
wants to merge 1 commit into from
Closed

Fixes enum autocompletetion showing class names with an underscore #35739

wants to merge 1 commit into from

Conversation

Janglee123
Copy link
Contributor

fixes #35469.

@Janglee123 Janglee123 force-pushed the autocompletetion-shows-starting-underscore-fix branch from 786aa41 to c13c53a Compare January 30, 2020 13:02
@vnen
Copy link
Member

vnen commented May 3, 2020

Change looks okay but needs a better commit message.

@Janglee123 Janglee123 force-pushed the autocompletetion-shows-starting-underscore-fix branch from c13c53a to 7ccae6c Compare May 4, 2020 08:14
@Calinou Calinou added this to the 4.0 milestone Jan 5, 2021
@akien-mga akien-mga removed the request for review from bojidar-bg July 5, 2022 10:20
@akien-mga
Copy link
Member

Welp, this went under the radar for a long time.

I've noticed that the bug is still reproducible on 3.x so this fix is likely still valid and useful there.

Not sure about master, would need to test. If it's still reproducible the fix would likely need to be put somewhere else as GDScript was fully rewritten in the meantime.

@akien-mga
Copy link
Member

Confirmed fixed in master already. I'll retarget this PR for 3.x.

@akien-mga akien-mga changed the base branch from master to 3.x July 5, 2022 10:25
@akien-mga akien-mga requested a review from a team as a code owner July 5, 2022 10:25
@akien-mga akien-mga mentioned this pull request Jul 5, 2022
Merged
@akien-mga
Copy link
Member

akien-mga commented Jul 5, 2022 •
edited
Loading

I couldn't force push to update @Janglee123's branch so I made a new PR with this fix rebased for 3.x: #62731.

Thanks for the fix BTW :)

@akien-mga akien-mga closed this Jul 5, 2022
@YuriSizov YuriSizov modified the milestones: 4.0, 3.x Feb 4, 2023
@YuriSizov YuriSizov removed this from the 3.x milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
archived bug topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum autocompletetion showing class names with an underscore
6 participants
@Janglee123 @vnen @akien-mga @Calinou @Chaosus @YuriSizov