Normalise p_up_direction vector in move_and_slide() #36079
Merged
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased following rename to |
move_and_slide_with_snap() and fix tolerance in move_and_slide_with_snap() max floor angle.
madmiraal
changed the title
|
Updated to include fix for #39506. |
akien-mga
approved these changes
Jun 16, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalises p_up_direction vector in move_and_slide() and move_and_slide_with_snap()
Also fixes tolerance in move_and_slide_with_snap() max floor angle, by making move_and_slide_with_snap() floor detection the same as move_and_slide().
Fixes #39506
Closes godotengine/godot-proposals#402