Vulkan: Implement environment fog and exponential fog #36989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shader code was taken from GLES3 implementation and 3.2 branch. The sun direction is now the direction of the first directional light (if there's any). Fixes godotengine#36654.
giarve
added a commit
to giarve/godot
that referenced
this pull request
Mar 14, 2020
Introduces a new parameter, exponential fog density, which allows a default for exponential fog while preserving fog's alpha color channel to specify fog density. The commit also adds missing hide_prefixes[] for height and depth fog properties. Requires godotengine#36989. Should fix godotengine#24596.
Calinou
reviewed
Mar 14, 2020
|
Does exponential fog only apply to depth fog, or can it also apply to height fog? This should be mentioned in the class reference. |
giarve
force-pushed
the
vulkan-fog-implementation
branch
from
64b8ebe to
1a47c7b
Compare
giarve
changed the title
giarve
force-pushed
the
vulkan-fog-implementation
branch
from
d9265f0 to
a1e27c4
Compare
Introduces a new parameter, exponential fog density, which allows a default for exponential fog while preserving fog's alpha color channel to specify fog density. The commit also adds missing hide_prefixes[] for height and depth fog properties. Apply suggestions from code review Co-Authored-By: Hugo Locurcio <hugo.locurcio@hugo.pro>
giarve
force-pushed
the
vulkan-fog-implementation
branch
from
a1e27c4 to
3f44038
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shader code was taken from GLES3 implementation and 3.2 branch.
The sun direction is now the direction of the first directional light (if there's any).
The commit Introduces a new parameter, exponential fog density, which allows a default for exponential fog while preserving fog's alpha color channel to specify fog density.
The commit also adds missing hide_prefixes[] for height and depth fog properties.
Exponential fog is enabled by default.
Fixes #36654.
Fixes #24596.
EDIT: Last push should fix CI build.